Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ephemeral Resources - azurerm_key_vault_secret azurerm_key_vault_certificate #28083

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Nov 21, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

These have all been lumped together due to time contraints, sorry!

  • Bumps terraform-plugin-testing for access to the echoprovider which is needed to check the values produced by an ephemeral resource
  • Adds the ProtoV6 provider factories, but only for the echoprovider for the time being
  • Sets the resource's context info for ephemeral resources which was panicking previously
  • Sets errors occurring in ephemeral resource specific methods e.g. Open, Renew, Close into the diags
  • Add two ephemeral resources azurerm_key_vault_secret and azurerm_key_vault_certificate

Testing

=== RUN   TestAccEphemeralKeyVaultSecret_basic
--- PASS: TestAccEphemeralKeyVaultSecret_basic (840.80s)
=== RUN   TestAccEphemeralKeyVaultSecret_complete
--- PASS: TestAccEphemeralKeyVaultSecret_complete (873.44s)
PASS
=== RUN   TestAccEphemeralKeyVaultCertificate_basic
--- PASS: TestAccEphemeralKeyVaultCertificate_basic (843.28s)
=== RUN   TestAccEphemeralKeyVaultCertificate_ecdsaPFX
--- PASS: TestAccEphemeralKeyVaultCertificate_ecdsaPFX (872.12s)
=== RUN   TestAccEphemeralKeyVaultCertificate_ecdsaPEM
--- PASS: TestAccEphemeralKeyVaultCertificate_ecdsaPEM (833.52s)
=== RUN   TestAccEphemeralKeyVaultCertificate_rsaBundlePEM
--- PASS: TestAccEphemeralKeyVaultCertificate_rsaBundlePEM (829.37s)
=== RUN   TestAccEphemeralKeyVaultCertificate_rsaSinglePEM
--- PASS: TestAccEphemeralKeyVaultCertificate_rsaSinglePEM (832.19s)
=== RUN   TestAccEphemeralKeyVaultCertificate_rsaBundlePFX
--- PASS: TestAccEphemeralKeyVaultCertificate_rsaBundlePFX (830.19s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/keyvault      5043.104s

These tests won't be able to run in TC until we bump some versions in the build agents we're using.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

NOTES:

FEATURES:

  • New Ephemeral Resource azurerm_key_vault_certificate
  • New Ephemeral Resource azurerm_key_vault_secret

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - one really minor comment below, otherwise LGTM 🐿️

…ice in docs that terraform 1.10+ is required for use
@stephybun stephybun merged commit 34e001d into main Nov 21, 2024
34 checks passed
@stephybun stephybun deleted the f/add-key-vault-secret-ephemeral-resource branch November 21, 2024 17:41
@github-actions github-actions bot added this to the v4.11.0 milestone Nov 21, 2024
stephybun added a commit that referenced this pull request Nov 21, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants